-keep-all-resources option to preserve optimized-out resources in DXIL reflection #7734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lection. This isn't default to avoid DXIL bloat and because apps might assume that if a resource is missing that it's optimized out and use this info to avoid transitions or other optimizations. When a resource is unused but still present, it won't emit a createHandle, but the reflection info will still be there
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces a new compiler option, -keep-all-resources, which ensures that even optimized-out resources are retained in DXIL reflection.
Motivation
By default, unused resources are removed during optimization, and applications may rely on their absence to infer optimization opportunities (e.g., skipping transitions). However, sometimes when reflection completeness is important (e.g., tools, debugging, visual scripting, or consistency with SPIR-V -Od) it is desirable to keep all declared resources visible in reflection, regardless of usage.
Behavior
When enabled, unused resources are not fully removed.
They will appear in reflection but will not generate createHandle instructions.
Notes
This is not enabled by default to avoid DXIL bloat and to prevent breaking apps that assume missing resources imply optimization.
Conflicts with #7729.
Step 2/2 to solve #5105.